bito-code-review[bot] commented on code in PR #43176:
URL: https://github.com/apache/superset/pull/43176#discussion_r4174220839
##########
superset/mcp_service/chart/compile.py:
##########
@@ -94,6 +94,7 @@ def _compile_chart(
Returns a :class:`CompileResult` with ``success=True`` when the
query executes cleanly.
"""
+ from superset.charts.data.form_data import set_query_context_form_data
Review Comment:
<!-- Bito Reply -->
The suggestion to move the function-local import to the module level is
appropriate. It aligns the code with the established project pattern used in
sibling tools and avoids unnecessary function-local imports, which is generally
preferred for clarity and consistency in this codebase.
**superset/mcp_service/chart/compile.py**
```
from superset.charts.data.form_data import set_query_context_form_data
def _compile_chart(
# ...
Returns a :class:`CompileResult` with ``success=True`` when the
query executes cleanly.
"""
# ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
