bito-code-review[bot] commented on code in PR #43176:
URL: https://github.com/apache/superset/pull/43176#discussion_r4174216365
##########
superset/common/tabular_query.py:
##########
@@ -397,6 +402,28 @@ def build_query_dict(
return query_dict
+def _time_range_from_filters(filters: Any) -> str | None:
Review Comment:
<!-- Bito Reply -->
The renaming of the helper function to `_temporal_range_in_filters` is a
positive change. It effectively resolves the potential for confusion with the
existing `_time_range_filters` function by providing a clearer, more distinct
name that better reflects its purpose.
**superset/common/tabular_query.py**
```
+def _temporal_range_in_filters(filters: Any) -> str | None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
