mikebridge opened a new pull request, #44999:
URL: https://github.com/apache/superset/pull/44999

   ### SUMMARY
   
   The Numerical range native filter discovers its slider bounds by running a 
MIN/MAX query on the column. Semantic views do not support that query (it 
relies on ad-hoc metrics, which providers such as Cube reject), so a Numerical 
range filter on a semantic-view dimension errored.
   
   For semantic views, the filter now offers labelled manual lower and upper 
bound inputs instead of a discovered slider, and sends no bounds query. An 
empty end is unbounded; required, invalid and non-finite values are rejected. 
SQL datasets keep bounds discovery and the slider unchanged.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   To follow after a browser check.
   
   ### TESTING INSTRUCTIONS
   
   - Red-first tests for the query, the range widget, the filter bar and the 
filter configuration: they failed before the change and pass now (92 passed 
across 7 suites).
   - Pre-commit hooks, type checks and the translation-template drift check 
pass.
   - Manual: on a dashboard with a semantic view, Edit filters → Numerical 
range → pick a numeric dimension. Expect manual bound inputs, no slider, and no 
bounds request on configure, open, refresh or cascade. Try one end empty, both 
empty, negatives and decimals, equal bounds, reversed bounds, and Clear All. 
Repeat with a SQL dataset to confirm the slider still works.
   - Not yet verified in a browser or against a live provider.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [x] Required feature flags: `SEMANTIC_LAYERS`
   - [x] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to