mikebridge commented on code in PR #44999:
URL: https://github.com/apache/superset/pull/44999#discussion_r4235516487
##########
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx:
##########
@@ -249,9 +257,12 @@ export default function RangeFilterPlugin(props:
PluginFilterRangeProps) {
isOverflowingFilterBar,
} = props;
+ const manualBounds = isSemanticRange(formData);
const [row] = data;
- // @ts-expect-error
- const { min, max }: { min: number; max: number } = row;
+ const min =
+ !manualBounds && typeof row?.min === 'number' ? row.min : undefined;
+ const max =
+ !manualBounds && typeof row?.max === 'number' ? row.max : undefined;
Review Comment:
Fixed in 5732d9044c: null min/max (empty or all-null column) now leaves the
range unbounded with usable inputs; only a present, non-numeric aggregate shows
the non-numeric message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
