Re: [PR] fix(filters): use manual semantic-view range bounds [superset]

Fri, 09 Oct 2026 10:38:16 -0700 


codeant-ai-for-open-source[bot] commented on code in PR #44999:
URL: https://github.com/apache/superset/pull/44999#discussion_r4232380660


##########
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx:
##########
@@ -249,9 +257,12 @@ export default function RangeFilterPlugin(props: 
PluginFilterRangeProps) {
     isOverflowingFilterBar,
   } = props;
 
+  const manualBounds = isSemanticRange(formData);
   const [row] = data;
-  // @ts-expect-error
-  const { min, max }: { min: number; max: number } = row;
+  const min =
+    !manualBounds && typeof row?.min === 'number' ? row.min : undefined;
+  const max =
+    !manualBounds && typeof row?.max === 'number' ? row.max : undefined;

Review Comment:
   **Suggestion:** An empty or all-null numeric dataset returns null 
aggregates; these checks make both bounds undefined, so the numeric-column 
guard falsely rejects the column.
   
   **Assessment:** ๐ŸŸ  `Major` ยท ๐Ÿ” `Occurrence: Rarely` ยท ๐Ÿท๏ธ `Incorrect condition 
logic`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4d83e6c3ed19446f8c2772cc8b1d0bb3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4d83e6c3ed19446f8c2772cc8b1d0bb3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent ๐Ÿค– </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** 
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx
   **Line:** 262:265
   **Comment:**
        *Incorrect Condition Logic: An empty or all-null numeric dataset 
returns null aggregates; these checks make both bounds undefined, so the 
numeric-column guard falsely rejects the column.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44999&comment_hash=768de3e2b82835b2a181730ea07b08dfa6befa9ee063fd36b216ad1f88c5f540&reaction=like'>๐Ÿ‘</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44999&comment_hash=768de3e2b82835b2a181730ea07b08dfa6befa9ee063fd36b216ad1f88c5f540&reaction=dislike'>๐Ÿ‘Ž</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to