sadpandajoe commented on code in PR #43695: URL: https://github.com/apache/superset/pull/43695#discussion_r4196195451
########## tests/unit_tests/db_engine_specs/test_lint_metadata.py: ########## @@ -0,0 +1,115 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, +# either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from pathlib import Path +from textwrap import dedent + +import pytest + +from superset.db_engine_specs.lint_metadata import get_all_engine_specs_ast + + +def _write_spec(directory: Path, filename: str, code: str) -> Path: + """Write a Python source file into *directory* and return the path.""" + spec_file = directory / filename + spec_file.write_text(dedent(code), encoding="utf-8") + return spec_file + + +def test_get_all_engine_specs_ast_annotated_attributes( + tmp_path: Path, + monkeypatch: pytest.MonkeyPatch, +) -> None: + """ + Engine specs with type-annotated engine, engine_name, and metadata + (inline initializers) are correctly discovered, including when named + with the *BaseEngineSpec suffix. + """ + _write_spec( + tmp_path, + "_tmp_typed_inline.py", + """\ + from typing import Any + from superset.db_engine_specs.base import BaseEngineSpec + + class TypedInlineBaseEngineSpec(BaseEngineSpec): + engine: str = "typed_engine" + engine_name: str = "Typed Engine" + metadata: dict[str, Any] = { Review Comment: The new `ast.Set` and unary-minus branches in `_eval_ast_value` have no coverage here: both fixtures only use string-valued metadata, so dropping either branch (it would silently return `None`) leaves every added linter test green. Could you add a fixture with a set-valued entry and a negative number, and assert the parsed metadata returns them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
