FrancescoCastaldi commented on code in PR #43695:
URL: https://github.com/apache/superset/pull/43695#discussion_r4256744478
##########
superset/db_engine_specs/databricks.py:
##########
@@ -629,9 +657,22 @@ class
DatabricksNativeEngineSpec(DatabricksDynamicBaseEngineSpec):
"databricks+connector://token:{access_token}@{host}:{port}/{database_name}"
)
- # Note: Primary metadata is in DatabricksPythonConnectorEngineSpec which
- # consolidates all Databricks connection methods. This spec exists for
- # backwards compatibility with legacy databricks-dbapi connections.
+ metadata = {
+ "description": ("Databricks legacy connector using databricks-dbapi."),
+ "logo": "databricks.png",
+ "homepage_url": "https://www.databricks.com/";,
+ "categories": [
+ DatabaseCategory.CLOUD_DATA_WAREHOUSES,
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.HOSTED_OPEN_SOURCE,
+ ],
+ "pypi_packages": ["databricks-dbapi[sqlalchemy]"],
Review Comment:
Updated. Registered `databricks.connector` in the SQLAlchemy dialect
registry to alias `databricks.sqlalchemy:DatabricksDialect`, ensuring
`databricks+connector://` URIs load cleanly under SQLAlchemy 2.0. Updated
`pypi_packages` to `["apache-superset[databricks]"]` and added regression
coverage for dialect resolution.
##########
superset/db_engine_specs/databricks.py:
##########
@@ -955,6 +980,29 @@ class DatabricksODBCEngineSpec(DatabricksBaseEngineSpec):
drivers = {"pyodbc": "ODBC driver for SQL endpoint"}
default_driver = "pyodbc"
+ metadata = {
+ "description": ("Databricks SQL Endpoint connectivity via the pyodbc
driver."),
+ "logo": "databricks.png",
+ "homepage_url": "https://www.databricks.com/";,
+ "categories": [
+ DatabaseCategory.CLOUD_DATA_WAREHOUSES,
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.PROPRIETARY,
+ ],
+ "pypi_packages": ["pyodbc"],
Review Comment:
Updated. `DatabricksODBCEngineSpec.metadata` now specifies
`["databricks-dbapi[sqlalchemy]"]` in `pypi_packages` so the required
`databricks+pyodbc` dialect is registered.
##########
superset/db_engine_specs/databricks.py:
##########
@@ -974,6 +1022,31 @@ class DatabricksHiveEngineSpec(HiveEngineSpec):
drivers = {"pyhive": "Hive driver for Interactive Cluster"}
default_driver = "pyhive"
+ metadata = {
+ "description": (
+ "Databricks Interactive Cluster connectivity via the PyHive
connector."
+ ),
+ "logo": "databricks.png",
+ "homepage_url": "https://www.databricks.com/";,
+ "categories": [
+ DatabaseCategory.CLOUD_DATA_WAREHOUSES,
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.HOSTED_OPEN_SOURCE,
+ ],
+ "pypi_packages": ["pyhive"],
Review Comment:
Updated. `DatabricksHiveEngineSpec.metadata` now lists
`["databricks-dbapi[sqlalchemy]"]` in `pypi_packages` to register the
`databricks+pyhive` dialect.
##########
superset/db_engine_specs/clickhouse.py:
##########
@@ -261,9 +261,25 @@ class ClickHouseEngineSpec(ClickHouseBaseEngineSpec):
_show_functions_column = "name"
supports_file_upload = False
- # Note: Primary metadata is in ClickHouseConnectEngineSpec which
consolidates
- # both drivers. This spec exists for backwards compatibility with existing
- # connections using the clickhouse-sqlalchemy driver.
+ metadata = {
+ "description": (
+ "ClickHouse is an open-source column-oriented database for
real-time "
+ "analytics using SQL (legacy clickhouse-sqlalchemy connector)."
+ ),
+ "logo": "clickhouse.png",
+ "homepage_url": "https://clickhouse.com/";,
+ "categories": [
+ DatabaseCategory.ANALYTICAL_DATABASES,
+ DatabaseCategory.OPEN_SOURCE,
+ ],
+ "pypi_packages": ["clickhouse-sqlalchemy"],
+ "connection_string": (
+ "clickhouse://{username}:{password}@{host}:{port}/{database}"
+ ),
+ "default_port": 8123,
+ "docs_url": "https://clickhouse.com/docs/";,
+ "sqlalchemy_docs_url":
"https://github.com/xzkostyan/clickhouse-sqlalchemy";,
Review Comment:
Updated. Set `sqlalchemy_docs_url` explicitly on
`ClickHouseConnectEngineSpec` pointing to
`https://clickhouse.com/docs/en/integrations/sql-clients/superset`, avoiding
inheritance of the legacy driver docs link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
