EnxDev commented on code in PR #45100:
URL: https://github.com/apache/superset/pull/45100#discussion_r4222456427
##########
superset/commands/semantic_layer/update.py:
##########
@@ -199,19 +214,12 @@ def run(self) -> Model:
self._properties["configuration"] = json.dumps(
self._properties["configuration"]
)
+ if "configuration" in self._properties:
+ self._model.clear_metadata_cache()
Review Comment:
The modal's Save always sends `configuration`
(`SemanticLayerModal.tsx:303`), so renaming a connection in the UI also bumps
`cache_version` and cold-starts every chart cache on that layer. The
"description-only edits don't increment" case only happens through the API.
Now that Reload metadata covers the explicit case, would it make sense to
bump only when the unmasked configuration actually differs from what's stored?
If bumping on every Save is intentional, ignore this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
