mikebridge commented on code in PR #45100:
URL: https://github.com/apache/superset/pull/45100#discussion_r4223372465
##########
superset/commands/semantic_layer/update.py:
##########
@@ -199,19 +214,12 @@ def run(self) -> Model:
self._properties["configuration"] = json.dumps(
self._properties["configuration"]
)
+ if "configuration" in self._properties:
+ self._model.clear_metadata_cache()
Review Comment:
You're right: a rename through this modal still submits `configuration`, so
it also invalidates the layer's caches. That's intentional in the Save
contract: submitting configuration is an invalidation point even when the
unmasked values match. A partial API update that omits configuration leaves the
version unchanged, and the existing regression covers both cases. "Reload
metadata" is the separate, explicit action. I'd keep it as is, since checking
configuration equality would change that policy, but happy to discuss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
