mikebridge commented on PR #45100: URL: https://github.com/apache/superset/pull/45100#issuecomment-6069587613
@sadpandajoe @EnxDev @aminghadersohi this is ready for review. It replaces the closed #44835/#44849/#44851 stack with a simpler approach: saving a semantic layer's configuration bumps a per-layer cache version (stored in the metadata DB, in the same transaction), and every metadata, result, compatibility and column-value cache key includes it, so an ordinary reload reads fresh metadata. A small "Reload metadata" action does the same for upstream-only changes. There's no snapshot store, leases or revalidation. It also removes the unused, unreleased refresh contract from #44834, keeping `metadata_cache_token`. The one red job (`sharded-jest-tests (5)`, `FiltersConfigModal.test.tsx`) is an unrelated timing flake. This PR doesn't touch native filters, the same failure appears on other PRs, and #45106 fixes it. Joe, given your depth on the previous stack, your eyes here would be especially valuable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
