mikebridge commented on PR #45173: URL: https://github.com/apache/superset/pull/45173#issuecomment-6129279038
Checked the queued-debounce concern at dc25bc9eb2554bf30302eacbcd96f61ce42cb91b: it is already handled. SemanticLayerModal.tsx:332 explicitly clears the pending timer in handleBack; line 322 invalidates requests already in flight, and lifecycle cleanup also clears the timer. A focused probe queued a refresh, clicked Back, selected another provider and advanced time: no old-provider request fired. Removing only line 332 made the probe fail (three requests instead of two); restoring it passed all 30 cases, including the probe. No code change was needed; the unchanged modal suite passes all 29 committed tests. Investigated with Codex; the existing exact-tree fix was independently reviewed by Claude. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
