mikebridge commented on code in PR #45173:
URL: https://github.com/apache/superset/pull/45173#discussion_r4254681800
##########
superset-frontend/src/features/semanticLayers/jsonFormsHelpers.tsx:
##########
@@ -248,7 +313,7 @@ export function DynamicFieldControl(props: ControlProps) {
}
if (!refreshing) {
- return TextControl(props);
+ return <SchemaTextControl {...props} />;
Review Comment:
Good catch — fixed in d9b70c6d610a7a577e8d173d2b03119ecd4a4894 by keeping
the idle suffix mounted. The real-renderer regression reproduces the dropped
second character and focus on body before the fix, then preserves both
characters, input identity and focus across refresh start/completion; all 81
semantic-layer tests and changed-file hooks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
