mikebridge commented on code in PR #45173:
URL: https://github.com/apache/superset/pull/45173#discussion_r4253216179
##########
superset-frontend/src/features/semanticLayers/SemanticLayerModal.tsx:
##########
@@ -321,13 +349,11 @@ export default function SemanticLayerModal({
addSuccessToast(t('Semantic layer created'));
}
onHide();
- } catch (error) {
- const clientError = await getClientErrorObject(error);
+ } catch {
Review Comment:
Good catch—fixed in dead2b64462e34804cdbeffccfd4dd4f8849c9eb. Save preserves
getClientErrorObject(error).error and uses the create/update fallback only when
empty. Duplicate-name, missing-field and masked-field reasons have red-first
coverage using actual 422 response decoding; both empty-message fallbacks are
covered too. All 80 focused tests and hooks pass. Implemented with Codex and
independently reviewed by Claude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
