FrancescoCastaldi commented on code in PR #43695:
URL: https://github.com/apache/superset/pull/43695#discussion_r4256922948
##########
superset/db_engine_specs/parseable.py:
##########
@@ -41,16 +41,19 @@ class ParseableEngineSpec(BaseEngineSpec):
"Parseable is a distributed log analytics database "
"with SQL-like query interface."
),
+ "logo": "parseable.png",
+ "homepage_url": "https://www.parseable.com";,
"categories": [DatabaseCategory.SEARCH_NOSQL,
DatabaseCategory.OPEN_SOURCE],
"pypi_packages": ["sqlalchemy-parseable"],
"connection_string": (
- "parseable://{username}:{password}@{hostname}:{port}/{stream_name}"
+
"parseable+http://{username}:{password}@{hostname}:{port}/{stream_name}";
),
+ "default_port": 8000,
"connection_examples": [
{
"description": "Example connection",
"connection_string": (
-
"parseable://admin:[email protected]:443/ingress-nginx"
+
"parseable+http://admin:[email protected]:443/ingress-nginx";
Review Comment:
Updated. The connection example retains parseable+https:// for
demo.parseable.com:443, while the default connection template uses
parseable+http:// for port 8000.
##########
tests/unit_tests/db_engine_specs/test_exasol.py:
##########
@@ -189,3 +225,4 @@ def test_extract_verbose_empty_diagnostic(diagnostic: str,
wrapped: bool) -> Non
assert errors[0].message == prefix + envelope.strip()
assert "code => 42000" in errors[0].message
assert sql not in errors[0].message
+>>>>>>> upstream/master
Review Comment:
Removed. The leftover merge conflict marker has been deleted and the test
suite collects cleanly.
##########
superset/db_engine_specs/lint_metadata.py:
##########
@@ -272,10 +276,17 @@ def get_all_engine_specs_ast() -> list[dict[str, Any]]:
# noqa: C901
if isinstance(item, ast.Assign):
for target in item.targets:
if isinstance(target, ast.Name) and target.id ==
"engine":
- # Check if engine value is non-empty string
if isinstance(item.value, ast.Constant):
has_non_empty_engine =
bool(item.value.value)
break
+ elif isinstance(item, ast.AnnAssign):
Review Comment:
Added. Included test_get_all_engine_specs_ast_annotated_attributes in
tests/unit_tests/db_engine_specs/test_lint_metadata.py, validating that class
attributes with type annotations and inline initializers are discovered and
their metadata preserved.
##########
superset/db_engine_specs/arc.py:
##########
@@ -42,9 +42,13 @@ class ArcEngineSpec(BaseEngineSpec):
metadata = {
"description": "Arc is a data platform with multiple connection
options.",
+ "logo": "arc.png",
Review Comment:
Updated. Dropped the logo entries from arc.py, ocient.py, odps.py, and
parseable.py until the corresponding image assets are added to the
documentation directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
