mikebridge commented on PR #45133: URL: https://github.com/apache/superset/pull/45133#issuecomment-6152901378
@aminghadersohi merged apache master and addressed its containment-cache interaction in https://github.com/apache/superset/commit/36626ab2e73c40723990a1048c94d59b8dee3379. The two UPDATING.md bullets are consolidated into one titled filter/SDK upgrade entry, retaining provider-adoption and annotation-cache guidance. OrFilter groups now have deterministic tagged identities and require identical group sets for reuse; they are never flattened or passed to leaf containment proofs. Cache identity v5 isolates older entries during rolling upgrades. Red-first evidence: 10 regression cases failed with the production repair reverted and passed after content-verified restoration; an additional member-definition case also failed before its guard and passes now. Final checks: 1,269 semantic-layer tests, 17 focused Jest tests, changed-file hooks and normal pre-push gates passed. Independent Claude review found no BLOCKER/HIGH; GitHub reports MERGEABLE and new-head CI is pending. Could you take another look at the consolidation and cache integration? Codex implementation, independently reviewed by Claude. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
