FrancescoCastaldi commented on PR #44945:
URL: https://github.com/apache/superset/pull/44945#issuecomment-6162937356
**Review 5513093578 (@sadpandajoe) - addressed in commit
3de1b061e3abb428b2463f7729eadf51d4dc57da**
Both review threads have been resolved:
1. **TypeScript TS2322 in `ControlForm.test.tsx` (comment 4266796574)**:
Passed `description=""` to both `ControlFormItem` instances (initial
render and rerender), satisfying `ControlFormItemDefaultSpec` and resolving
TS2322 in `lint-frontend`.
2. **Null handling in unpersisted default commit guard (comment
4266796578)**:
Updated `isUnpersistedDefault` in `RadioButtonControl.tsx` to use
`props.initialValue == null` and `value == null` instead of strictly `===
undefined`. This matches the component's fallback behavior (`value ??
normalizedOptions[0]?.value`), allowing a displayed default to be committed via
`onChange` when `value={null}` or `initialValue={null}`.
Added unit tests in `RadioButtonControl.test.tsx` covering both `value:
null` and `initialValue: null`.
@sadpandajoe, ready for re-review when convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
