villebro opened a new pull request #9322: fix: handle list of lists from fetch_data URL: https://github.com/apache/incubator-superset/pull/9322 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [x] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Currently `SupersetResultSet` is unable to handle results that are coming in as a list of lists. This causes trouble later when converting the result into a numpy array. While the convention for PEP-249 is to return a list of tuples, this is not strictly enforced, and hence many connectors return a list of lists. This PR ensures that the result set is a list of lists that numpy can handle properly. A test case is also added that fails without the change. ### BEFORE  ### AFTER  ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @robdiciuccio @dpgaspar @kunaldawn
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
