villebro commented on a change in pull request #9322: fix: handle list of lists
from fetch_data
URL:
https://github.com/apache/incubator-superset/pull/9322#discussion_r394301377
##########
File path: tests/result_set_tests.py
##########
@@ -109,6 +109,13 @@ def test_int64_with_missing_data(self):
results = SupersetResultSet(data, cursor_descr, BaseEngineSpec)
self.assertEqual(results.columns[0]["type"], "BIGINT")
+ def test_data_from_list_of_lists(self):
+ data = [["a"], ["b"]]
+ cursor_descr = [("user_id", "STRING", None, None, None, None, True)]
Review comment:
Good point, I'll change the description to list of list here to tackle both
cases in one test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
