robdiciuccio commented on a change in pull request #9322: fix: handle list of
lists from fetch_data
URL:
https://github.com/apache/incubator-superset/pull/9322#discussion_r394523858
##########
File path: superset/result_set.py
##########
@@ -97,7 +98,7 @@ def __init__(
# put data in a structured array so we can efficiently access each
column.
# cast `data` as list due to MySQL (others?) wrapping results with a
tuple.
- array = np.array(list(data), dtype=numpy_dtype)
+ array = np.array([tuple(row) for row in data], dtype=numpy_dtype)
Review comment:
Looking at this again, can iteration over the data be avoided here? This
could potentially be very expensive for large datasets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
