john-bodley commented on a change in pull request #9943:
URL:
https://github.com/apache/incubator-superset/pull/9943#discussion_r434086449
##########
File path: superset/app.py
##########
@@ -109,8 +111,8 @@ class AppContextTask(task_base): # type: ignore
abstract = True
# Grab each call into the task and set up an app context
- def __call__(self, *args, **kwargs):
- with flask_app.app_context():
+ def __call__(self, *args: Any, **kwargs: Any) -> Any:
+ with flask_app.app_context(): # type: ignore
Review comment:
@serenajiang `mypy` does use these stubs. I presume the Flask types
aren't fully flushed out. I plan on creating a follow up PR which will check
for erroneous `# type: ignore` comments which then can be removed as `mypy`
continues to evolve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
