villebro commented on a change in pull request #9943:
URL:
https://github.com/apache/incubator-superset/pull/9943#discussion_r434185547
##########
File path: superset/viz.py
##########
@@ -2367,7 +2382,7 @@ def query_obj(self):
d["columns"] = gb
return d
- def get_js_columns(self, d):
+ def get_js_columns(self, d: Dict[str, Any]) -> Dict[str, Any]:
Review comment:
😄 I'm sure it has, kudos for this work! I think we need to bump
`pylint` first, as the current version isn't compatible with `3.7`. I'm looking
to see if there's interest in the community to help with that effort, as it
might be a good task to get acquainted with the codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
