john-bodley commented on a change in pull request #9943:
URL:
https://github.com/apache/incubator-superset/pull/9943#discussion_r434891778
##########
File path: superset/viz.py
##########
@@ -2367,7 +2382,7 @@ def query_obj(self):
d["columns"] = gb
return d
- def get_js_columns(self, d):
+ def get_js_columns(self, d: Dict[str, Any]) -> Dict[str, Any]:
Review comment:
Agreed regarding bumping `pylint` (this is actually mentioned in the
SIP) as I ran into an issue trying to use a newer feature. I'm not sure if we
can automate this, but periodically I think it's good that we go through and
bump all our dependencies which should help us be more nimble to accommodate us
supporting more recent Python versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
