madisonmlin commented on code in PR #3995:
URL: https://github.com/apache/texera/pull/3995#discussion_r2471169830
##########
file-service/src/main/scala/org/apache/texera/service/util/S3StorageClient.scala:
##########
@@ -51,6 +56,29 @@ object S3StorageClient {
.build()
}
+ // Initialize S3-compatible presigner for LakeFS S3 Gateway
+ private lazy val s3Presigner: S3Presigner = {
+ val fullUri = new URI(StorageConfig.lakefsEndpoint)
Review Comment:
I don't believe so. If we don't override to specify the endpoint our
s3Presigner should go through, it will use the default AWS endpoint. Then, the
generated presigned URL will point to AWS instead of LakeFS and won't be able
to get the file we want.
##########
file-service/src/main/scala/org/apache/texera/service/util/S3StorageClient.scala:
##########
@@ -51,6 +57,31 @@ object S3StorageClient {
.build()
}
+ // Initialize S3-compatible presigner for LakeFS S3 Gateway
+ private lazy val s3Presigner: S3Presigner = {
+ val lakefsCredentials =
+ AwsBasicCredentials.create(StorageConfig.lakefsUsername,
StorageConfig.lakefsPassword)
Review Comment:
s3Credentials and lakefsCredentials use different username and password, so
it's not exactly repeated. Should I unify this into a separate helper?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
