madisonmlin commented on code in PR #3995:
URL: https://github.com/apache/texera/pull/3995#discussion_r2471589945
##########
file-service/src/main/scala/org/apache/texera/service/util/S3StorageClient.scala:
##########
@@ -51,6 +56,29 @@ object S3StorageClient {
.build()
}
+ // Initialize S3-compatible presigner for LakeFS S3 Gateway
+ private lazy val s3Presigner: S3Presigner = {
+ val fullUri = new URI(StorageConfig.lakefsEndpoint)
Review Comment:
The previous presigner used LakeFS's own API, so it already implicitly knew
its own endpoint through the LakeFS config. However, the s3Presigner is a
generic AWS SDK tool that MinIO happens to be compatible with. It isn't
intended solely for LakeFS. As such, it defaults to the AWS S3 endpoint unless
explicitly overriden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
