aicam commented on code in PR #3995:
URL: https://github.com/apache/texera/pull/3995#discussion_r2471279510
##########
file-service/src/main/scala/org/apache/texera/service/util/S3StorageClient.scala:
##########
@@ -51,6 +56,29 @@ object S3StorageClient {
.build()
}
+ // Initialize S3-compatible presigner for LakeFS S3 Gateway
+ private lazy val s3Presigner: S3Presigner = {
+ val fullUri = new URI(StorageConfig.lakefsEndpoint)
Review Comment:
I don't understand why AWS is involved here. AWS provides libraries to use
MinIO because MinIO is using same protocol, However, it should not cause any
issue for us. Currently, the path to MinIO is defined in LakeFS config (called
blockstore), and it was using it in previous S3 signed URL generation, why its
not using that anymore? maybe a better question is: Why your implementation
needs to override baseURL but previous one didn't?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
