Yicong-Huang commented on code in PR #4158:
URL: https://github.com/apache/texera/pull/4158#discussion_r2692453075
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/controller/WorkflowScheduler.scala:
##########
@@ -45,7 +45,7 @@ class WorkflowScheduler(
// CostBasedRegionPlanGenerator considers costs to try to find an
optimal plan.
new CostBasedScheduleGenerator(
workflowContext,
- physicalPlan,
+ physicalPlan.copy(executionMode =
workflowContext.workflowSettings.executionMode),
Review Comment:
I don't think this setting should be part of Physical plan. The information
is already in workflowContext, why duplicate it again in physical plan?
##########
frontend/src/app/dashboard/component/user/user-workflow/user-workflow.component.ts:
##########
@@ -230,7 +230,10 @@ export class UserWorkflowComponent implements
AfterViewInit {
commentBoxes: [],
links: [],
operatorPositions: {},
- settings: { dataTransferBatchSize:
this.config.env.defaultDataTransferBatchSize },
+ settings: {
+ dataTransferBatchSize: this.config.env.defaultDataTransferBatchSize,
+ executionMode: ExecutionMode.STREAMING,
Review Comment:
make it configurable? similar to `dataTransferBatchSize`
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/controller/WorkflowScheduler.scala:
##########
@@ -45,7 +45,7 @@ class WorkflowScheduler(
// CostBasedRegionPlanGenerator considers costs to try to find an
optimal plan.
new CostBasedScheduleGenerator(
workflowContext,
- physicalPlan,
+ physicalPlan.copy(executionMode =
workflowContext.workflowSettings.executionMode),
Review Comment:
In fact, please do not add such configuration to physical plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
