aglinxinyuan commented on code in PR #4158:
URL: https://github.com/apache/texera/pull/4158#discussion_r2696517130
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/controller/WorkflowScheduler.scala:
##########
@@ -45,7 +45,7 @@ class WorkflowScheduler(
// CostBasedRegionPlanGenerator considers costs to try to find an
optimal plan.
new CostBasedScheduleGenerator(
workflowContext,
- physicalPlan,
+ physicalPlan.copy(executionMode =
workflowContext.workflowSettings.executionMode),
Review Comment:
I don’t think it’s true that the physical plan will be exactly the same
regardless of how we execute it. If you look at the line 52, this.physicalPlan
= updatedPhysicalPlan, the physical plan clearly changes before and after
CostBasedScheduleGenerator, so the physical plan changes based on the execution
plan.
We may need input from @Xiao-zhen-Liu to understand why Pasta needs to
modify the physical plan and whether this behavior is intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
