Yicong-Huang commented on code in PR #4158:
URL: https://github.com/apache/texera/pull/4158#discussion_r2696500734
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/controller/WorkflowScheduler.scala:
##########
@@ -45,7 +45,7 @@ class WorkflowScheduler(
// CostBasedRegionPlanGenerator considers costs to try to find an
optimal plan.
new CostBasedScheduleGenerator(
workflowContext,
- physicalPlan,
+ physicalPlan.copy(executionMode =
workflowContext.workflowSettings.executionMode),
Review Comment:
I cannot agree.
I think physical plan should be exactly same, no matter how we execute it.
If it got changed then we need to revisit previous decisions. The execution
plan will be different, based on how we cut the regions and how we do
materializations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
