kunwp1 commented on code in PR #4268:
URL: https://github.com/apache/texera/pull/4268#discussion_r3105598747
##########
frontend/src/app/workspace/types/workflow-compiling.interface.ts:
##########
@@ -70,8 +70,50 @@ export type CompilationStateInfo = Readonly<
operatorErrors: Readonly<Record<string, WorkflowFatalError>>;
}
>;
+
// possible types of an attribute
-export type AttributeType = "string" | "integer" | "double" | "boolean" |
"long" | "timestamp" | "binary"; // schema: an array of attribute names and
types
+// Canonical frontend / JSON schema names
+export type AttributeType =
+ | "string"
+ | "integer"
+ | "long"
+ | "double"
+ | "boolean"
+ | "timestamp"
+ | "binary"
+ | "large_binary";
+
+// Java enum constant names (AttributeType.java)
+export const JAVA_ATTRIBUTE_TYPE_NAMES = [
Review Comment:
It looks like JAVA_ATTRIBUTE_TYPE_NAMES, JavaAttributeTypeName, and the
other related tokens defined in `workflow-compiling-interface.ts` are only used
within `ui-udf-parameters-parser.service.ts`. To better follow the principle of
colocation and reduce unnecessary cross-file dependencies, I suggest we move
these definitions directly into the service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
