carloea2 commented on code in PR #4268:
URL: https://github.com/apache/texera/pull/4268#discussion_r3105616636


##########
amber/src/main/python/pytexera/__init__.py:
##########
@@ -53,4 +54,7 @@
     "Iterator",
     "Optional",
     "Union",
+    "Dict",

Review Comment:
   @kunwp1 NameError: name 'Dict' is not defined
   2026-04-18 12:17:21.586 | ERROR    | 
core.architecture.rpc.async_rpc_server:receive:102 - name 'Dict' is not defined
   Traceback (most recent call last):
   
     File 
"C:\Users\carlo\AppData\Local\Programs\Python\Python312\Lib\threading.py", line 
1032, in _bootstrap
       self._bootstrap_inner()
       |    -> <function Thread._bootstrap_inner at 0x0000016D4CABF600>
       -> <Thread(main_loop_thread, started 32596)>
     File 
"C:\Users\carlo\AppData\Local\Programs\Python\Python312\Lib\threading.py", line 
1075, in _bootstrap_inner
       self.run()
       |    -> <function Thread.run at 0x0000016D4CABF2E0>
       -> <Thread(main_loop_thread, started 32596)>
     File 
"C:\Users\carlo\AppData\Local\Programs\Python\Python312\Lib\threading.py", line 
1012, in run
       self._target(*self._args, **self._kwargs)
       |    |        |    |        |    -> {}
       |    |        |    |        -> <Thread(main_loop_thread, started 32596)>
       |    |        |    -> ()
       |    |        -> <Thread(main_loop_thread, started 32596)>
       |    -> <bound method StoppableQueueBlockingRunnable.run of 
<core.runnables.main_loop.MainLoop object at 0x0000016D03002270>>
       -> <Thread(main_loop_thread, started 32596)>
   
     File 
"C:\Users\carlo\texera\texera\amber\src\main\python\core\util\stoppable\stoppable_queue_blocking_thread.py",
 line 65, in run
       self.receive(self.interruptible_get())
       |    |       |    -> <function 
StoppableQueueBlockingRunnable.interruptible_get at 0x0000016D7F8FACA0>
       |    |       -> <core.runnables.main_loop.MainLoop object at 
0x0000016D03002270>
       |    -> <function MainLoop.receive at 0x0000016D02F84C20>
       -> <core.runnables.main_loop.MainLoop object at 0x0000016D03002270>
   
     File 
"C:\Users\carlo\texera\texera\amber\src\main\python\core\runnables\main_loop.py",
 line 142, in receive
       match(
       -> <function match at 0x0000016D001AE480>
   
     File 
"C:\Users\carlo\texera\texera\.venv312\Lib\site-packages\pampy\pampy.py", line 
299, in match
       return run(action, lambda_args)
              |   |       -> 
[DCMElement(tag=ChannelIdentity(from_worker_id=ActorVirtualIdentity(name='CONTROLLER'),
 to_worker_id=ActorVirtualIdentity(nam...
              |   -> <bound method MainLoop._process_dcm of 
<core.runnables.main_loop.MainLoop object at 0x0000016D03002270>>
              -> <function run at 0x0000016D001AD580>
     File 
"C:\Users\carlo\texera\texera\.venv312\Lib\site-packages\pampy\pampy.py", line 
48, in run
       return action(*var)
              |       -> 
[DCMElement(tag=ChannelIdentity(from_worker_id=ActorVirtualIdentity(name='CONTROLLER'),
 to_worker_id=ActorVirtualIdentity(nam...
              -> <bound method MainLoop._process_dcm of 
<core.runnables.main_loop.MainLoop object at 0x0000016D03002270>>
   
     File 
"C:\Users\carlo\texera\texera\amber\src\main\python\core\runnables\main_loop.py",
 line 224, in _process_dcm
       match(
       -> <function match at 0x0000016D001AE480>
   
     File 
"C:\Users\carlo\texera\texera\.venv312\Lib\site-packages\pampy\pampy.py", line 
299, in match
       return run(action, lambda_args)
              |   |       -> 
[ChannelIdentity(from_worker_id=ActorVirtualIdentity(name='CONTROLLER'), 
to_worker_id=ActorVirtualIdentity(name='Worker:WF78-...
              |   -> <bound method AsyncRPCServer.receive of 
<core.architecture.rpc.async_rpc_server.AsyncRPCServer object at 
0x0000016D03002690>>
              -> <function run at 0x0000016D001AD580>
     File 
"C:\Users\carlo\texera\texera\.venv312\Lib\site-packages\pampy\pampy.py", line 
48, in run
       return action(*var)
              |       -> 
[ChannelIdentity(from_worker_id=ActorVirtualIdentity(name='CONTROLLER'), 
to_worker_id=ActorVirtualIdentity(name='Worker:WF78-...
              -> <bound method AsyncRPCServer.receive of 
<core.architecture.rpc.async_rpc_server.AsyncRPCServer object at 
0x0000016D03002690>>
   
   > File 
"C:\Users\carlo\texera\texera\amber\src\main\python\core\architecture\rpc\async_rpc_server.py",
 line 94, in receive
       asyncio.run(handler.func(control_payload_stream))
       |       |   |       |    -> 
<core.architecture.rpc.async_rpc_server.AsyncRPCServer._wrap_as_stream.<locals>.ControlRequestStream
 object at 0x0000016D0300...
       |       |   |       -> _tuplegetter(0, 'Alias for field number 0')
       |       |   -> Handler(func=<bound method 
WorkerServiceBase.__rpc_initialize_executor of 
<core.architecture.rpc.async_rpc_handler_initialize...
       |       -> <function run at 0x0000016D4CD31DA0>
       -> <module 'asyncio' from 
'C:\\Users\\carlo\\AppData\\Local\\Programs\\Python\\Python312\\Lib\\asyncio\\__init__.py'>
   
     File 
"C:\Users\carlo\AppData\Local\Programs\Python\Python312\Lib\asyncio\runners.py",
 line 195, in run
       return runner.run(main)
              |      |   -> <coroutine object 
WorkerServiceBase.__rpc_initialize_executor at 0x0000016D02FB1D20>
              |      -> <function Runner.run at 0x0000016D4CFAB240>
              -> <asyncio.runners.Runner object at 0x0000016D030014C0>
     File 
"C:\Users\carlo\AppData\Local\Programs\Python\Python312\Lib\asyncio\runners.py",
 line 118, in run
       return self._loop.run_until_complete(task)
              |    |                        -> <Task finished name='Task-1' 
coro=<WorkerServiceBase.__rpc_initialize_executor() done, defined at 
C:\Users\carlo\texera\texer...
              |    -> None
              -> <asyncio.runners.Runner object at 0x0000016D030014C0>
     File 
"C:\Users\carlo\AppData\Local\Programs\Python\Python312\Lib\asyncio\base_events.py",
 line 691, in run_until_complete
       return future.result()
              |      -> <method 'result' of '_asyncio.Task' objects>
              -> <Task finished name='Task-1' 
coro=<WorkerServiceBase.__rpc_initialize_executor() done, defined at 
C:\Users\carlo\texera\texer...
   
     File 
"C:\Users\carlo\texera\texera\amber\src\main\python\proto\org\apache\texera\amber\engine\architecture\rpc\__init__.py",
 line 1597, in __rpc_initialize_executor
       response = await self.initialize_executor(request)
                        |    |                   -> 
InitializeExecutorRequest(total_worker_count=1, 
op_exec_init_info=OpExecInitInfo(op_exec_with_code=OpExecWithCode(code='# Cho...
                        |    -> <function 
InitializeExecutorHandler.initialize_executor at 0x0000016D02F720C0>
                        -> 
<core.architecture.rpc.async_rpc_handler_initializer.AsyncRPCHandlerInitializer 
object at 0x0000016D02EFB320>
   
     File 
"C:\Users\carlo\texera\texera\amber\src\main\python\core\architecture\handlers\control\initialize_executor_handler.py",
 line 30, in initialize_executor
       self.context.executor_manager.initialize_executor(
       |    |       |                -> <function 
ExecutorManager.initialize_executor at 0x0000016D02F51440>
       |    |       -> 
<core.architecture.managers.executor_manager.ExecutorManager object at 
0x0000016D030022D0>
       |    -> <core.architecture.managers.context.Context object at 
0x0000016D030022A0>
       -> 
<core.architecture.rpc.async_rpc_handler_initializer.AsyncRPCHandlerInitializer 
object at 0x0000016D02EFB320>
   
     File 
"C:\Users\carlo\texera\texera\amber\src\main\python\core\architecture\managers\executor_manager.py",
 line 151, in initialize_executor
       executor: type(Operator) = self.load_executor_definition(code)
                      |           |    |                        -> '# Choose 
from the following templates:\n# \n# UiParameter notes:\n# - A UiParameter is a 
user-editable value exposed in the ...
                      |           |    -> <function 
ExecutorManager.load_executor_definition at 0x0000016D02F51260>
                      |           -> 
<core.architecture.managers.executor_manager.ExecutorManager object at 
0x0000016D030022D0>
                      -> <class 'core.models.operator.Operator'>
   
     File 
"C:\Users\carlo\texera\texera\amber\src\main\python\core\architecture\managers\executor_manager.py",
 line 93, in load_executor_definition
       executor_module = importlib.import_module(module_name)
                         |         |             -> 'udf-v1'
                         |         -> <function import_module at 
0x0000016D4CB6D080>
                         -> <module 'importlib' from 
'C:\\Users\\carlo\\AppData\\Local\\Programs\\Python\\Python312\\Lib\\importlib\\__init__.py'>
   
     File 
"C:\Users\carlo\AppData\Local\Programs\Python\Python312\Lib\importlib\__init__.py",
 line 90, in import_module
       return _bootstrap._gcd_import(name[level:], package, level)
              |          |           |    |        |        -> 0
              |          |           |    |        -> None
              |          |           |    -> 0
              |          |           -> 'udf-v1'
              |          -> <function _gcd_import at 0x0000016D4C48C0E0>
              -> <module '_frozen_importlib' (frozen)>
     File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
     File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
     File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
     File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
     File "<frozen importlib._bootstrap_external>", line 999, in exec_module
     File "<frozen importlib._bootstrap>", line 488, in 
_call_with_frames_removed
   
     File "C:\Users\carlo\AppData\Local\Temp\tmpkqz8h60kfsTempFS\udf-v1.py", 
line 12, in <module>
       class ProcessTupleOperator(UDFOperatorV2):
                                  -> <class 
'pytexera.udf.udf_operator.UDFOperatorV2'>
   
     File "C:\Users\carlo\AppData\Local\Temp\tmpkqz8h60kfsTempFS\udf-v1.py", 
line 30, in ProcessTupleOperator
       def _texera_injected_ui_parameters(self) -> Dict[str, Any]:
   
   NameError: name 'Dict' is not defined



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to