aglinxinyuan commented on PR #4268: URL: https://github.com/apache/texera/pull/4268#issuecomment-4309041057
We should aim to keep PRs as small as possible unless you can clearly prove that a PR cannot be split. I don’t think that’s the case here. Breaking a larger prototype into smaller PRs can also help you think more carefully about how to modularize your code. While we don’t have a strict limit on PR size, in my experience, anything with more than ~500 lines of additions is usually too large—unless it’s primarily refactoring (e.g., moving existing code without significant changes) or includes generated files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
