Yicong-Huang commented on PR #4268: URL: https://github.com/apache/texera/pull/4268#issuecomment-4310537192
It's all about communication: in Pr context, it is communication between PR author and the reviewer. Larger PRs usually get fewer and shallower reviews. A huge PR is almost equivalent to being unreviewable. I agree with Xinyuan. A reasonable rule of thumb is that the source-code of a PR should ideally be around 200 LoC, with 500 LoC as a rough upper bound, and should usually touch fewer than 10 files. Test files can be a bit bigger and usually reviewers pay less effort to review tests. Of course, this also depends on the language and the nature of the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
