gracecluvohio commented on code in PR #36: URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3150780882
########## content/en/docs/contribution-guidelines/_index.md: ########## @@ -39,8 +39,17 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo ### 3. Create and Submit a Pull Request - Develop in a new branch of your fork. + > **Modifying the SQL schema?** - > Be sure to update `sql/changelog.xml` and omit `\c texera_db` from the top of your SQL update file — Liquibase cannot parse this line. + > 1. Be sure to update `sql/changelog.xml` by adding a new `<changeSet>` element. + > 2. The file format of your SQL update file should be: + > ``` + > SET search_path TO texera_db; + > BEGIN; + > [your changes here] + > COMMIT; + > ``` + > Prior SQL update files had the line `\c texera_db` at the top, but this should be omitted — Liquibase cannot parse this line. Review Comment: > does this mean developers should manually omit \c texera_db from new SQL update files? It means that going forward, developers who add a new SQL update file should not include it. > Since running the SQL update file through Liquibase is optional, would removing this line cause any issues when developers run the file manually without Liquibase? It would, developers would need to make sure they connect to `texera_db` before they apply the change using the old method. Not sure if this is an issue, but if it is, I can think of some ways to address it. 1. Going forward, require all developers to use `docker compose up` under the `sql` directory to apply new schema changes. 2. Keep the old format with `\c texera_db`, but in the docker compose file, create a small script that strips lines starting with `\c` before applying the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
