mengw15 commented on code in PR #36: URL: https://github.com/apache/incubator-texera-site/pull/36#discussion_r3151677572
########## content/en/docs/contribution-guidelines/_index.md: ########## @@ -39,8 +39,17 @@ Fork the [Texera repository](https://github.com/Texera/texera) on GitHub and clo ### 3. Create and Submit a Pull Request - Develop in a new branch of your fork. + > **Modifying the SQL schema?** - > Be sure to update `sql/changelog.xml` and omit `\c texera_db` from the top of your SQL update file — Liquibase cannot parse this line. + > 1. Be sure to update `sql/changelog.xml` by adding a new `<changeSet>` element. + > 2. The file format of your SQL update file should be: + > ``` + > SET search_path TO texera_db; + > BEGIN; + > [your changes here] + > COMMIT; + > ``` + > Prior SQL update files had the line `\c texera_db` at the top, but this should be omitted — Liquibase cannot parse this line. Review Comment: I think this feature should be an add-on — it shouldn't change the existing developer experience, and the convention across update files should stay consistent. With that in mind, I'd suggest going with the option of keeping \c texera_db in the SQL files and stripping it in the docker compose entrypoint before handing off to Liquibase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
