Yicong-Huang commented on code in PR #4276:
URL: https://github.com/apache/texera/pull/4276#discussion_r3214131493
##########
.github/workflows/build.yml:
##########
@@ -331,6 +333,71 @@ jobs:
run: psql -h localhost -U postgres -v DB_NAME=texera_db_for_test_cases
-f sql/texera_ddl.sql
env:
PGPASSWORD: postgres
+ - name: Start MinIO
+ run: |
+ docker run -d --name minio --network host \
+ -e MINIO_ROOT_USER=texera_minio \
+ -e MINIO_ROOT_PASSWORD=password \
+ minio/minio:RELEASE.2025-02-28T09-55-16Z server /data
+ for i in $(seq 1 30); do
+ curl -sf http://localhost:9000/minio/health/live && break
+ echo "Waiting for MinIO... (attempt $i)"
+ sleep 2
+ done
+ - name: Start Lakekeeper
+ env:
+ LAKEKEEPER__PG_DATABASE_URL_READ:
postgres://postgres:postgres@localhost:5432/texera_lakekeeper
+ LAKEKEEPER__PG_DATABASE_URL_WRITE:
postgres://postgres:postgres@localhost:5432/texera_lakekeeper
+ LAKEKEEPER__PG_ENCRYPTION_KEY: texera_key
+ run: |
+ docker run --rm --network host \
+ -e LAKEKEEPER__PG_DATABASE_URL_READ \
+ -e LAKEKEEPER__PG_DATABASE_URL_WRITE \
+ -e LAKEKEEPER__PG_ENCRYPTION_KEY \
+ vakamo/lakekeeper:v0.11.0 migrate
+ docker run -d --name lakekeeper --network host \
+ -e LAKEKEEPER__PG_DATABASE_URL_READ \
+ -e LAKEKEEPER__PG_DATABASE_URL_WRITE \
+ -e LAKEKEEPER__PG_ENCRYPTION_KEY \
+ -e LAKEKEEPER__METRICS_PORT=9091 \
+ vakamo/lakekeeper:v0.11.0 serve
+ for i in $(seq 1 30); do
+ docker exec lakekeeper /home/nonroot/lakekeeper healthcheck &&
break
+ echo "Waiting for Lakekeeper... (attempt $i)"
+ sleep 2
+ done
+ docker exec lakekeeper /home/nonroot/lakekeeper healthcheck || {
+ echo "Lakekeeper failed to start. Container logs:"
+ docker logs lakekeeper
+ exit 1
+ }
+ - name: Initialize Lakekeeper warehouse
+ run: |
+ docker run --rm --network host --entrypoint sh minio/mc -c \
+ "mc alias set minio http://localhost:9000 texera_minio password &&
\
+ mc mb --ignore-existing minio/texera-iceberg"
+ curl -sf -X POST -H 'Content-Type: application/json' \
+ -d
'{"project-id":"00000000-0000-0000-0000-000000000000","project-name":"default"}'
\
+ http://localhost:8181/management/v1/project || true
+ curl -sf -X POST -H 'Content-Type: application/json' -d '{
+ "warehouse-name": "texera",
+ "project-id": "00000000-0000-0000-0000-000000000000",
+ "storage-profile": {
+ "type": "s3",
+ "bucket": "texera-iceberg",
+ "region": "us-west-2",
+ "endpoint": "http://localhost:9000";,
+ "flavor": "s3-compat",
+ "path-style-access": true,
+ "sts-enabled": false
+ },
+ "storage-credential": {
+ "type": "s3",
+ "credential-type": "access-key",
+ "aws-access-key-id": "texera_minio",
+ "aws-secret-access-key": "password"
+ }
Review Comment:
do those config live some where in our codebase? can we point there instead?
this is to avoid the need to update this CI file when we need to change some
parameter.
##########
.github/workflows/build.yml:
##########
@@ -331,6 +333,71 @@ jobs:
run: psql -h localhost -U postgres -v DB_NAME=texera_db_for_test_cases
-f sql/texera_ddl.sql
env:
PGPASSWORD: postgres
+ - name: Start MinIO
+ run: |
+ docker run -d --name minio --network host \
+ -e MINIO_ROOT_USER=texera_minio \
+ -e MINIO_ROOT_PASSWORD=password \
+ minio/minio:RELEASE.2025-02-28T09-55-16Z server /data
+ for i in $(seq 1 30); do
+ curl -sf http://localhost:9000/minio/health/live && break
+ echo "Waiting for MinIO... (attempt $i)"
+ sleep 2
+ done
Review Comment:
every CI second counts. this currently looks 60s before timeout. can we
tighten it?
##########
.github/workflows/build.yml:
##########
@@ -524,7 +594,7 @@ jobs:
if [ -f amber/dev-requirements.txt ]; then uv pip install --system
-r amber/dev-requirements.txt; fi
- name: Test with pytest
run: |
- cd amber && pytest --cov=src/main/python --cov-report=xml -sv
+ cd amber && pytest -m "not integration" --cov=src/main/python
--cov-report=xml -sv
Review Comment:
so for normal python CI job, we should skip integration as well right?
##########
.github/workflows/build.yml:
##########
@@ -331,6 +333,71 @@ jobs:
run: psql -h localhost -U postgres -v DB_NAME=texera_db_for_test_cases
-f sql/texera_ddl.sql
env:
PGPASSWORD: postgres
+ - name: Start MinIO
+ run: |
+ docker run -d --name minio --network host \
+ -e MINIO_ROOT_USER=texera_minio \
+ -e MINIO_ROOT_PASSWORD=password \
+ minio/minio:RELEASE.2025-02-28T09-55-16Z server /data
+ for i in $(seq 1 30); do
+ curl -sf http://localhost:9000/minio/health/live && break
+ echo "Waiting for MinIO... (attempt $i)"
+ sleep 2
+ done
+ - name: Start Lakekeeper
+ env:
+ LAKEKEEPER__PG_DATABASE_URL_READ:
postgres://postgres:postgres@localhost:5432/texera_lakekeeper
+ LAKEKEEPER__PG_DATABASE_URL_WRITE:
postgres://postgres:postgres@localhost:5432/texera_lakekeeper
+ LAKEKEEPER__PG_ENCRYPTION_KEY: texera_key
+ run: |
+ docker run --rm --network host \
+ -e LAKEKEEPER__PG_DATABASE_URL_READ \
+ -e LAKEKEEPER__PG_DATABASE_URL_WRITE \
+ -e LAKEKEEPER__PG_ENCRYPTION_KEY \
+ vakamo/lakekeeper:v0.11.0 migrate
+ docker run -d --name lakekeeper --network host \
+ -e LAKEKEEPER__PG_DATABASE_URL_READ \
+ -e LAKEKEEPER__PG_DATABASE_URL_WRITE \
+ -e LAKEKEEPER__PG_ENCRYPTION_KEY \
+ -e LAKEKEEPER__METRICS_PORT=9091 \
+ vakamo/lakekeeper:v0.11.0 serve
+ for i in $(seq 1 30); do
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
