Yicong-Huang commented on code in PR #4276:
URL: https://github.com/apache/texera/pull/4276#discussion_r3215060265
##########
.github/workflows/build.yml:
##########
@@ -331,6 +333,71 @@ jobs:
run: psql -h localhost -U postgres -v DB_NAME=texera_db_for_test_cases
-f sql/texera_ddl.sql
env:
PGPASSWORD: postgres
+ - name: Start MinIO
+ run: |
+ docker run -d --name minio --network host \
+ -e MINIO_ROOT_USER=texera_minio \
+ -e MINIO_ROOT_PASSWORD=password \
+ minio/minio:RELEASE.2025-02-28T09-55-16Z server /data
+ for i in $(seq 1 30); do
+ curl -sf http://localhost:9000/minio/health/live && break
+ echo "Waiting for MinIO... (attempt $i)"
+ sleep 2
+ done
+ - name: Start Lakekeeper
+ env:
+ LAKEKEEPER__PG_DATABASE_URL_READ:
postgres://postgres:postgres@localhost:5432/texera_lakekeeper
+ LAKEKEEPER__PG_DATABASE_URL_WRITE:
postgres://postgres:postgres@localhost:5432/texera_lakekeeper
+ LAKEKEEPER__PG_ENCRYPTION_KEY: texera_key
+ run: |
+ docker run --rm --network host \
+ -e LAKEKEEPER__PG_DATABASE_URL_READ \
+ -e LAKEKEEPER__PG_DATABASE_URL_WRITE \
+ -e LAKEKEEPER__PG_ENCRYPTION_KEY \
+ vakamo/lakekeeper:v0.11.0 migrate
+ docker run -d --name lakekeeper --network host \
+ -e LAKEKEEPER__PG_DATABASE_URL_READ \
+ -e LAKEKEEPER__PG_DATABASE_URL_WRITE \
+ -e LAKEKEEPER__PG_ENCRYPTION_KEY \
+ -e LAKEKEEPER__METRICS_PORT=9091 \
+ vakamo/lakekeeper:v0.11.0 serve
+ for i in $(seq 1 30); do
Review Comment:
Yes success runs will not change. But for failure runs, we previously need
to wait 1 minute to abort, now we only need 3 seconds. My gut feeling is that
most of those services should start in milliseconds, and if not, waiting more
seconds doesn't help, and that's a waste on the CI seconds. We might as well
just abort early. Keep in mind that every second you add to CI will be executed
multiple times on every PR, so it's good to be cautious and only add necessary
ones.
If 3 seconds is stable, i.e., most runs can success, then let's go with
this. We can gradually increase it if we see unstableness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
