mengw15 commented on code in PR #4276:
URL: https://github.com/apache/texera/pull/4276#discussion_r3214637935
##########
.github/workflows/build.yml:
##########
@@ -331,6 +333,71 @@ jobs:
run: psql -h localhost -U postgres -v DB_NAME=texera_db_for_test_cases
-f sql/texera_ddl.sql
env:
PGPASSWORD: postgres
+ - name: Start MinIO
+ run: |
+ docker run -d --name minio --network host \
+ -e MINIO_ROOT_USER=texera_minio \
+ -e MINIO_ROOT_PASSWORD=password \
+ minio/minio:RELEASE.2025-02-28T09-55-16Z server /data
+ for i in $(seq 1 30); do
+ curl -sf http://localhost:9000/minio/health/live && break
+ echo "Waiting for MinIO... (attempt $i)"
+ sleep 2
+ done
+ - name: Start Lakekeeper
+ env:
+ LAKEKEEPER__PG_DATABASE_URL_READ:
postgres://postgres:postgres@localhost:5432/texera_lakekeeper
+ LAKEKEEPER__PG_DATABASE_URL_WRITE:
postgres://postgres:postgres@localhost:5432/texera_lakekeeper
+ LAKEKEEPER__PG_ENCRYPTION_KEY: texera_key
+ run: |
+ docker run --rm --network host \
+ -e LAKEKEEPER__PG_DATABASE_URL_READ \
+ -e LAKEKEEPER__PG_DATABASE_URL_WRITE \
+ -e LAKEKEEPER__PG_ENCRYPTION_KEY \
+ vakamo/lakekeeper:v0.11.0 migrate
+ docker run -d --name lakekeeper --network host \
+ -e LAKEKEEPER__PG_DATABASE_URL_READ \
+ -e LAKEKEEPER__PG_DATABASE_URL_WRITE \
+ -e LAKEKEEPER__PG_ENCRYPTION_KEY \
+ -e LAKEKEEPER__METRICS_PORT=9091 \
+ vakamo/lakekeeper:v0.11.0 serve
+ for i in $(seq 1 30); do
Review Comment:
Tightened both to 3×1s = 3s. One question: do we really need the cap this
short? Since break exits on the first successful health check, the happy path
is already short — the cap only affects fail cases. So tightening it doesn't
speed up the success path (which is most runs), and a too-tight cap risks false
fails when boot times vary → CI re-run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
