Copilot commented on code in PR #5017:
URL: https://github.com/apache/texera/pull/5017#discussion_r3215766208
##########
frontend/angular.json:
##########
@@ -98,6 +98,16 @@
"**/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts"
]
}
+ },
+ "test-browser": {
+ "builder": "@angular/build:unit-test",
+ "options": {
+ "buildTarget": "gui:build:test",
+ "runner": "vitest",
+ "runnerConfig": "vitest.browser.config.ts",
+ "tsConfig": "src/tsconfig.spec.json",
+ "include":
["**/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts"]
+ }
Review Comment:
The new `test-browser` target is not referenced by any script/CI entrypoint,
while the default `test` target still excludes
`workflow-editor.component.spec.ts`. As a result, CI will continue to skip this
suite entirely. Consider updating `test:ci` / the GitHub Actions frontend job
to also run `ng run gui:test-browser` (likely gated to ubuntu-only) so the
browser-only suite is executed on every PR.
##########
frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts:
##########
@@ -74,10 +74,16 @@ describe("WorkflowEditorComponent", () => {
let fixture: ComponentFixture<WorkflowEditorComponent>;
let jointGraph: joint.dia.Graph;
- beforeEach(waitForAsync(() => {
- TestBed.configureTestingModule({
- declarations: [WorkflowEditorComponent, ContextMenuComponent],
- imports: [RouterTestingModule, HttpClientTestingModule, NzModalModule,
NzDropDownModule],
+ beforeEach(async () => {
+ await TestBed.configureTestingModule({
+ imports: [
Review Comment:
`waitForAsync` is no longer used after switching the hooks to
`async`/`await`, but it is still imported from `@angular/core/testing`. This
leaves an unused import that can fail linting (or confuse future edits). Remove
`waitForAsync` from the import list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
