Yicong-Huang commented on code in PR #5017:
URL: https://github.com/apache/texera/pull/5017#discussion_r3215789746
##########
frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts:
##########
@@ -74,10 +74,16 @@ describe("WorkflowEditorComponent", () => {
let fixture: ComponentFixture<WorkflowEditorComponent>;
let jointGraph: joint.dia.Graph;
- beforeEach(waitForAsync(() => {
- TestBed.configureTestingModule({
- declarations: [WorkflowEditorComponent, ContextMenuComponent],
- imports: [RouterTestingModule, HttpClientTestingModule, NzModalModule,
NzDropDownModule],
+ beforeEach(async () => {
+ await TestBed.configureTestingModule({
+ imports: [
Review Comment:
Done — dropped `waitForAsync` from the `@angular/core/testing` import in
f7eff95.
##########
frontend/angular.json:
##########
@@ -98,6 +98,16 @@
"**/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts"
]
}
+ },
+ "test-browser": {
+ "builder": "@angular/build:unit-test",
+ "options": {
+ "buildTarget": "gui:build:test",
+ "runner": "vitest",
+ "runnerConfig": "vitest.browser.config.ts",
+ "tsConfig": "src/tsconfig.spec.json",
+ "include":
["**/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts"]
+ }
Review Comment:
Good catch — wired in f7eff95: a new "Run frontend browser-mode tests" step
runs `yarn --cwd frontend ng run gui:test-browser` after the existing unit-test
step. Playwright Chromium is installed with `--with-deps` on Ubuntu and without
on macOS/Windows, and the step runs on all three matrix OSes so we catch any
platform-specific Vitest browser/Playwright surprises.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
