mengw15 commented on PR #4988: URL: https://github.com/apache/texera/pull/4988#issuecomment-4423948574
> > These two tests are testing the createRestCatalog in Scala and python. so this PR is covered end-to-end. With CI passed, I think we can confirm that this change works. > > sg. thanks! let's also make sure the coverage is filled, this can make sure your changes in this PR are actually being tested in the CI. > > > ❌ Patch coverage is `0%` with `3 lines` in your changes missing coverage. Please review.✅ Project coverage is 42.75%. Comparing base ([`14f8be4`](https://app.codecov.io/gh/apache/texera/commit/14f8be4c0856dd9f0be2aa594bdfe46a92f9d4cd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b7b3f84`](https://app.codecov.io/gh/apache/texera/commit/b7b3f8440de654510ed22cf9e291c655b0ee7dbb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > > Files with missing lines Patch % Lines > ...ala/org/apache/texera/amber/util/IcebergUtil.scala 0.00% 3 Missing ⚠️ > See more [#4988 (comment)](https://github.com/apache/texera/pull/4988#issuecomment-4409770046) It seems like the amber-integration job doesn't upload to Codecov. Added a mock unit test in IcebergUtilSpec to satisfy the patch number; it just drives createRestCatalog until .initialize throws (no Lakekeeper in unit-test scope). Real coverage still comes from the integration test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
