mengw15 commented on PR #4988: URL: https://github.com/apache/texera/pull/4988#issuecomment-4464159797
> Yes integration test is for now designed not to alter coverage report: we rely on unit tests. The unit test I added in IcebergUtilSpec is coverage-only — without a running Lakekeeper, RESTCatalog wraps the connection failure into RESTException The PR's real semantics (client sends only warehouse + uri, Lakekeeper resolves S3 config from the warehouse record) can only be verified end-to-end against a running Lakekeeper. That's what IcebergRestCatalogIntegrationSpec covers in amber-integration. For a real test in a coverage-uploading job, we'd need to add Lakekeeper (+ MinIO + Postgres) to the amber job — basically duplicating the service setup that amber-integration already does. Want me to do that, or is the current coverage-only test fine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
