mengw15 commented on code in PR #4988:
URL: https://github.com/apache/texera/pull/4988#discussion_r3253205504
##########
common/workflow-core/src/test/scala/org/apache/texera/amber/util/IcebergUtilSpec.scala:
##########
@@ -298,4 +299,13 @@ class IcebergUtilSpec extends AnyFlatSpec {
assert(IcebergUtil.fromRecord(record, schema) == tuple)
}
+
+ it should "build REST catalog properties without S3 settings" in {
Review Comment:
The name comes from this PR's change — `createRestCatalog` used to take S3
settings and no longer does, so the test exercises that new no-S3 call. Fair
point that this isn't obvious without the PR context; will rename to describe
what the assertion actually checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
