kunwp1 commented on code in PR #6866:
URL: https://github.com/apache/texera/pull/6866#discussion_r3736549551
##########
bin/mounter/mounter.py:
##########
Review Comment:
The mounter seems to not have an authentication (no auth on mount/unmount).
For example, CU pod A can send cuid=B and unmount CU pod B's dataset.
Also, I do see that the cuid, repo, and commit go straight into
os.path.join(MOUNT_ROOT, cuid, repo, commit). Can you confirm and reject any
cuid, repo, commit containing path separators or `..`?
##########
bin/k8s/templates/base/workflow-computing-unit-manager/workflow-computing-unit-manager-deployment.yaml:
##########
@@ -64,6 +64,8 @@ spec:
value: {{ .Values.workflowComputingUnitPool.namespace }}
- name: KUBERNETES_COMPUTE_UNIT_SERVICE_NAME
value: {{ .Values.workflowComputingUnitPool.name }}-svc
+ - name: KUBERNETES_COMPUTE_UNIT_POD_NAME_PREFIX
Review Comment:
Shouldn't you also inject the KUBERNETES_MOUNTER_PORT and
KUBERNETES_MOUNTER_HOST_ROOT from the helm values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
