aicam commented on code in PR #6866:
URL: https://github.com/apache/texera/pull/6866#discussion_r3779431765
##########
bin/k8s/templates/base/workflow-computing-unit-manager/workflow-computing-unit-manager-deployment.yaml:
##########
@@ -64,6 +64,8 @@ spec:
value: {{ .Values.workflowComputingUnitPool.namespace }}
- name: KUBERNETES_COMPUTE_UNIT_SERVICE_NAME
value: {{ .Values.workflowComputingUnitPool.name }}-svc
+ - name: KUBERNETES_COMPUTE_UNIT_POD_NAME_PREFIX
Review Comment:
I don't think so, for configurations that typically use default value we
don't add them to values.yaml because they always have default value. For
example, we don't put `KUBERNETES_COMPUTE_UNIT_POOL_NAMESPACE` in values.yaml
because we always use the default `texera-workflow-computing-unit-pool` value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
