kunwp1 commented on code in PR #6866:
URL: https://github.com/apache/texera/pull/6866#discussion_r3780121455
##########
bin/k8s/templates/base/workflow-computing-unit-manager/workflow-computing-unit-manager-deployment.yaml:
##########
@@ -64,6 +64,8 @@ spec:
value: {{ .Values.workflowComputingUnitPool.namespace }}
- name: KUBERNETES_COMPUTE_UNIT_SERVICE_NAME
value: {{ .Values.workflowComputingUnitPool.name }}-svc
+ - name: KUBERNETES_COMPUTE_UNIT_POD_NAME_PREFIX
Review Comment:
The issue is different from `KUBERNETES_COMPUTE_UNIT_POOL_NAMESPACE`. In
your comment, you mentioned that the Helm values must match the manager's
`kubernetes.mounter-port` and `kubernetes.mounter-host-root`. But currently,
the parameters are exposed to `Values.yaml` and Helm updates only the DaemonSet
and the manager always falls back to `kubernetes.conf` defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
