Yicong-Huang commented on PR #7664: URL: https://github.com/apache/texera/pull/7664#issuecomment-5299638254
> Many Texera features require a valid email, so after signing in with ORCID the user is prompted by a modal to attach one. I think this is a big topic, as it changes the account serving model. I do believe we have many features that rely on emails. Especially we have communication features (comment, share, future email notifications for executions etc.) I would strongly suggest we make email NON optional for all accounts. The current model essentially allows a partial account without an email. There are two concerns with the current model: 1. What if after sign up, user never provides email? in our codebase we have to handle this scenario, which adds complexity. I really want to prevent that from happening, unless we really have the need to allow optional email. 2. How do we know the email they entered is owned by the user? we will have to do some verification e.g., send a code to their email and ask them to enter it. I feel this step could just be required before they sign up with ORCID. for example, - at registration form, provide an input box for email and a button for verification. - After clicking the verification, an email with a code will be sent to the one they entered. an input box with verification code will be shown for user to enter, and a button for verify will also be shown. - After they verified with the correct code, the URCID login button shows up. Even further: a better way is to always require an email or an oauth with an email to login. And after that user can optionally link their ORCID in account settings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
