Neilk1021 commented on PR #7664: URL: https://github.com/apache/texera/pull/7664#issuecomment-5299785801
> 1. What if after sign up, user never provides email? in our codebase we have to handle this scenario, which adds complexity. I really want to prevent that from happening, unless we really have the need to allow optional email. If I recall correctly, the way it's implemented signs out the user if they refuse to provide an email, thus preventing them from using the service until one is provided. However, the guards on this could be stronger. > 2. How do we know the email they entered is owned by the user? we will have to do some verification e.g., send a code to their email and ask them to enter it. I should mention that this is already a problem we have with the current log-in system. Addition verification seemed out of scope for this specific PR, but I agree it needs to be added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
