aglinxinyuan opened a new pull request, #8926:
URL: https://github.com/apache/texera/pull/8926

   ### What changes were proposed in this PR?
   
   Removes two selectors from the global stylesheet's Python-environment modal 
(`.pve-modal`) block that match no element. **+1/−8 lines.** There is no 
behaviour change.
   
   - **The `.pve-modal .system-header .subtitle` rule.** The only 
`.system-header` element (in the computing-unit selection modal) contains just 
a `.title`. No template, TS code or ng-zorro component produces a bare 
`subtitle` class.
   - **The bare `.package-inputs` token in `.package-header-row, 
.package-inputs`.** The rule and `.package-header-row` stay. The templates use 
`system-package-inputs` and `user-package-inputs`, and CSS matches whole class 
tokens, so neither matches `.package-inputs`.
   
   Because these are global styles, the check covered every template and TS 
file in the app, plus ng-zorro's compiled output.
   
   ### History
   
   | | |
   | --- | --- |
   | **Introduced by** | #4484 (2026-05-01), "feat: Add Python Virtual 
Environment Support: Creating a Virtual Environment", which added the whole 
`.pve-modal` block |
   | **Usage removed by** | #4902 (2026-05-12), "Installing User Defined 
Packages", renamed the element to `system-package-inputs`, which left 
`.package-inputs` unmatched. `.subtitle` was **never used** |
   
   `.package-inputs` has been dead for nearly five months.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8925
   
   ### How was this PR tested?
   
   No new tests; no spec referenced either selector.
   
   From `frontend/`:
   
   - `npx ng test --watch=false --include='**/user-venv.component.spec.ts' 
--include='**/computing-unit-selection.component.spec.ts'`: 2 files, 242 tests, 
all pass. These are the only specs that render the modal.
   - `yarn format:ci`: clean.
   - `npx ng build`: success.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5.5)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to