tanishqgandhi1908 commented on PR #8890: URL: https://github.com/apache/texera/pull/8890#issuecomment-6181555304
> Can you address the comments? Also, > > 1. Can you add more test cases to make the code coverage 100%? > 2. Can you check if computing unit also has a similar issue? Thanks for the review! Addressed in 1019982c7: Coverage: Codecov only counts common/resource’s own tests for this code, so I added ResourceAccessSpec there, plus tests in the search and computing-unit specs. They all fail without the change. Computing units had the same issue. The owner’s access can no longer be changed, the unit info treats the owner as WRITE, and the access list hides a leftover owner row. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
