tanishqgandhi1908 commented on code in PR #8890:
URL: https://github.com/apache/texera/pull/8890#discussion_r4343390510
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/resource/ComputingUnitManagingResource.scala:
##########
@@ -884,22 +884,15 @@ class ComputingUnitManagingResource {
statusReason = if (isOwner) statusReason else None,
metrics = ComputingUnitHelpers.getComputingUnitMetrics(unit),
isOwner = isOwner,
- accessPrivilege = {
- val cuAccessDao = new
ComputingUnitUserAccessDao(context.configuration())
- val access = cuAccessDao
- .fetchByUid(user.getUid)
- .asScala
- .find(access => access.getCuid.equals(cuid))
-
- if (access.isDefined) {
- access.get.getPrivilege
- } else if (unit.getUid.equals(user.getUid)) {
- PrivilegeEnum.WRITE
- } else {
- // Default privilege for non-owners without explicit access
- PrivilegeEnum.NONE
- }
- },
+ accessPrivilege =
+ if (isOwner) PrivilegeEnum.WRITE
+ else
+ new ComputingUnitUserAccessDao(context.configuration())
+ .fetchByUid(user.getUid)
+ .asScala
+ .find(access => access.getCuid.equals(cuid))
+ .map(_.getPrivilege)
+ .getOrElse(PrivilegeEnum.NONE),
Review Comment:
Done, it now uses ComputingUnitAccess.getComputingUnitAccess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
